Skip to content
This repository was archived by the owner on Oct 5, 2022. It is now read-only.

Adding OTP grid card functionality #131

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

multiwebinc
Copy link

I edited Core.php inline, but yet github is finding all these differences. I only added 3 new lines.

@xqus
Copy link
Contributor

xqus commented Nov 3, 2014

Hi,
Thank you for the pull request. Looks nice.
However, Is it possible to split it into two different PR? Seems like there si two different changes going on here?

@multiwebinc
Copy link
Author

I'm sorry but I find github ridiculously confusing and difficult to use. If you could do that for me, that would be awesome. I thought I did, but I guess it all went into one.

Anyway, the commits on Sep 9 should be one PR and the ones on Sep 12 should be another PR.

@hablutzel1
Copy link

I just published a demonstration application using Gridcard class and you can read about it at https://blobfish.pe/blog/grid-card-for-two-factor-authentication/.

@multiwebinc
Copy link
Author

@hablutzel1 Oh hey. Neat! Glad you found the code useful. Keep in mind that compared with other two factor authentication methods, I would consider this to be significantly weaker, simply because it can be reproduced very easily. If you leave the card lying on your desk someone just has to pull out their phone and snap a picture of it and they have duplicated it 100%, whereas hardware dongles, or TOTP like Google Authenticator on your phone are not as easily duplicated. Also, if someone is able to intercept the values you send to the server, after 20-30 authentications they would have practically your whole card, unless you expire them.

Then again, it's extremely cheap to produce and doesn't require a phone or expensive devices and does add another layer of security.

My bank uses it too (which is where I got the idea from), so either it's not really that bad, or my bank is not really that good:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants