Skip to content

Conversation

@toonjanssens
Copy link
Contributor

No description provided.

@aderuwe
Copy link
Contributor

aderuwe commented Dec 9, 2015

@toonjanssens Given that we might want to extract more stuff from the README to its own files, could you please move the tasks into doc/tasks?

Other than that, big 👍 from me.

@aderuwe aderuwe changed the title Extract tasks into seperate files #49 Extract tasks into seperate files (Fixes #49) Dec 9, 2015
@veewee
Copy link
Contributor

veewee commented Dec 10, 2015

Some small remarks:
The docs/phpcs_framework_presets.md should be a chapter underneath php-cs.
The 'task' main title doesn't seem usefull.

Thanks!

@veewee
Copy link
Contributor

veewee commented Dec 11, 2015

Can you also add a link to the new Grunt task?
This one is already in doc/tasks. You might want to rebase against master.

veewee added a commit that referenced this pull request Dec 11, 2015
Extract tasks into seperate files (Fixes #49)
@veewee veewee merged commit 6d675b4 into phpro:master Dec 11, 2015
@veewee
Copy link
Contributor

veewee commented Dec 11, 2015

Thanks! We will work on improving the documentation in the next few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants