Fix active state for nested URLs in navigation#184
Closed
robinheidrich wants to merge 2 commits intophpmyadmin:masterfrom
Closed
Fix active state for nested URLs in navigation#184robinheidrich wants to merge 2 commits intophpmyadmin:masterfrom
robinheidrich wants to merge 2 commits intophpmyadmin:masterfrom
Conversation
Contributor
Author
|
Sorry, forgot to start from the right tree. I'll open a new PR! |
Member
By the way, you can force push PRs to avoid closing them |
Contributor
Author
|
Good to know, thanks! I've never really worked with PRs before 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where menu items are not shown as active when you are on a nested URL.
Example: