Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ALTER FUNCTION and ALTER PROCEDURE statements #553

Merged

Conversation

niconoe-
Copy link
Contributor

@niconoe- niconoe- commented Mar 1, 2024

Add support for ALTER FUNCTION and ALTER PROCEDURE statements.

The ABNF for those statements are exactly the same since MySQL 5.0 to latest MariaDb version:

2 commits are done: the first with everything but the options definitions in case of ALTER PROCEDURE or ALTER FUNCTION, causing all *.out data files giving the error "Unrecognized alter operation." we are trying to solve. The second commit applies the options definitions, so you can see that the related *.out files are updated to no longer have the parser error, but the full options built instead.

@williamdes It's been a long time 😄 . I'll not be back for so long, but I never come back with empty hands 😆 .

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.79%. Comparing base (716d545) to head (edc7db8).
Report is 4 commits behind head on 5.9.x.

Additional details and impacted files
@@            Coverage Diff            @@
##              5.9.x     #553   +/-   ##
=========================================
  Coverage     96.79%   96.79%           
- Complexity     2257     2259    +2     
=========================================
  Files            69       69           
  Lines          5172     5174    +2     
=========================================
+ Hits           5006     5008    +2     
  Misses          166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this all looks good to me
@kamil-tekiela what do you think ?

Copy link
Contributor

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine.

@williamdes williamdes added this to the 5.10.0 milestone Mar 6, 2024
@niconoe-
Copy link
Contributor Author

niconoe- commented Mar 7, 2024

I'm glad you valid this 🙂

I'm having the Benchmark on PHP 8.0 not passing, but I don't understand why. Is this a blocking point preventing this PR to be merged? If yes, how can I handle this please?

Thanks a lot!

@williamdes williamdes changed the title Feature/support alter routine Add support for ALTER FUNCTION and ALTER PROCEDURE statements May 9, 2024
@williamdes williamdes self-assigned this May 9, 2024
@williamdes williamdes changed the base branch from 5.9.x to 5.10.x May 9, 2024 08:26
@williamdes williamdes merged commit 896b02e into phpmyadmin:5.10.x May 9, 2024
15 of 19 checks passed
@niconoe- niconoe- deleted the feature/support-alter-routine branch August 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants