-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ALTER FUNCTION
and ALTER PROCEDURE
statements
#553
Add support for ALTER FUNCTION
and ALTER PROCEDURE
statements
#553
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.9.x #553 +/- ##
=========================================
Coverage 96.79% 96.79%
- Complexity 2257 2259 +2
=========================================
Files 69 69
Lines 5172 5174 +2
=========================================
+ Hits 5006 5008 +2
Misses 166 166 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this all looks good to me
@kamil-tekiela what do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine.
I'm glad you valid this 🙂 I'm having the Benchmark on PHP 8.0 not passing, but I don't understand why. Is this a blocking point preventing this PR to be merged? If yes, how can I handle this please? Thanks a lot! |
ALTER FUNCTION
and ALTER PROCEDURE
statements
Add support for
ALTER FUNCTION
andALTER PROCEDURE
statements.The ABNF for those statements are exactly the same since MySQL 5.0 to latest MariaDb version:
2 commits are done: the first with everything but the options definitions in case of
ALTER PROCEDURE
orALTER FUNCTION
, causing all*.out
data files giving the error "Unrecognized alter operation." we are trying to solve. The second commit applies the options definitions, so you can see that the related*.out
files are updated to no longer have the parser error, but the full options built instead.@williamdes It's been a long time 😄 . I'll not be back for so long, but I never come back with empty hands 😆 .