compatibility with PHP 8.1 (ArrayAccess)

[SailorMax]

Do you plan to add compatibility with PHP 8.1?

Currently I have next messages:
PHP Deprecated: Return type of PhpMyAdmin\SqlParser\TokensList::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar://sql-parser.phar/src/TokensList.php on line 184

Deprecated: Return type of PhpMyAdmin\SqlParser\TokensList::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar://sql-parser.phar/src/TokensList.php on line 172

PHP Deprecated: Return type of PhpMyAdmin\SqlParser\TokensList::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar://sql-parser.phar/src/TokensList.php on line 156

PHP Deprecated: Return type of PhpMyAdmin\SqlParser\TokensList::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar://sql-parser.phar/src/TokensList.php on line 194

[ibennetch]

Could you please tell us which phpMyAdmin version you have and how you installed it (package manager, direct download, etc)?

[SailorMax]

I use it separately. Today made "git pull", compiled as phar file and run it in EditPlus.

[ibennetch]

Ah, yes, I understand now.

However, I'm having some trouble reproducing this. Could you please provide a sample query that causes these warnings (or do the warnings appear regardless of what queries you run)? Is it with a particular action (such as trying to highlight a query)?

[SailorMax]

Looks like my description was wrong. This happens with PHP 8.1!

In my case any SQL return this.
For example

SELECT * FROM foo;

[ibennetch]

Interesting. That's exactly what I tried (from the command line interface, though), and I tested with both PHP 8.0 and 8.1.

Now I'll try building a phar myself to see if that's related.

[williamdes]

Note that our PHP 8.1 CI runs green: https://github.com/phpmyadmin/sql-parser/runs/3782153624?check_suite_focus=true

And that the array access issue is normally fixed with ed900e5

[SailorMax]

I run it on Windows with php 8.1RC3.
My build has this "fix"

here is my phar: https://tmpfiles.org/dl/135612/sql-parser.phar

[SailorMax]

I use it by this code:

$query = file_get_contents($sqlFileName);
$lexer = new PhpMyAdmin\SqlParser\Lexer($query);
$parser = new PhpMyAdmin\SqlParser\Parser($lexer->list);
$errors = PhpMyAdmin\SqlParser\Utils\Error::get(array($lexer, $parser));

[williamdes]

maybe the phar program removes code comments 🤔

[SailorMax]

Hmm, I decompressed phar and it has wrong sources...
Possible mistake from my side.

[SailorMax]

Yes. Sorry. My mistake.

[ibennetch]

Glad you got it sorted out!