-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Use composer/ca-bundle to manage the CA cert file
#17143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17143 +/- ##
============================================
+ Coverage 47.72% 47.74% +0.01%
+ Complexity 16666 16663 -3
============================================
Files 577 577
Lines 60535 60533 -2
============================================
+ Hits 28889 28900 +11
+ Misses 31646 31633 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
de35f7b to
8ac047b
Compare
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
8ac047b to
e5f9012
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a brilliant idea!
| @@ -21,6 +21,8 @@ phpMyAdmin - ChangeLog | |||
| - issue #16425 Add "DELETE FROM" table on table operations page | |||
| - issue #16482 Add a select all link for table-specific privileges | |||
| - issue #14276 Add support for account locking | |||
| - issue #17143 Use composer/ca-bundle to manage the CA cert file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now we can start using PR ids?
Does the changelog page work great afterwards since it parses the ids to issues urls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. GitHub redirects to the pull request page.
Uses the
composer/ca-bundlepackage to handle thecacert.pemfile.The
opensslPHP extension is now required.