Skip to content

Use composer/ca-bundle to manage the CA cert file #17143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2021

Conversation

MauricioFauth
Copy link
Member

Uses the composer/ca-bundle package to handle the cacert.pem file.

Small utility library that lets you find a path to the system CA bundle, and includes a fallback to the Mozilla CA bundle.

The openssl PHP extension is now required.

@MauricioFauth MauricioFauth added this to the 5.2.0 milestone Oct 9, 2021
@MauricioFauth MauricioFauth self-assigned this Oct 9, 2021
@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #17143 (e5f9012) into master (7da1f22) will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #17143      +/-   ##
============================================
+ Coverage     47.72%   47.74%   +0.01%     
+ Complexity    16666    16663       -3     
============================================
  Files           577      577              
  Lines         60535    60533       -2     
============================================
+ Hits          28889    28900      +11     
+ Misses        31646    31633      -13     
Flag Coverage Δ
dbase-extension 47.48% <80.00%> (-0.01%) ⬇️
recode-extension 47.43% <80.00%> (+0.01%) ⬆️
unit-7.2-ubuntu-latest 47.42% <80.00%> (-0.04%) ⬇️
unit-7.3-ubuntu-latest 50.44% <80.00%> (+0.01%) ⬆️
unit-7.4-ubuntu-latest 50.41% <80.00%> (-0.03%) ⬇️
unit-8.0-ubuntu-latest 50.52% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libraries/classes/Utils/HttpRequest.php 78.64% <80.00%> (+1.49%) ⬆️
...ries/classes/Plugins/Auth/AuthenticationConfig.php 70.14% <0.00%> (-5.98%) ⬇️
libraries/classes/Header.php 89.32% <0.00%> (-1.07%) ⬇️
libraries/classes/Transformations.php 60.60% <0.00%> (-0.51%) ⬇️
libraries/classes/Util.php 53.45% <0.00%> (+0.09%) ⬆️
libraries/classes/StorageEngine.php 69.00% <0.00%> (+0.50%) ⬆️
libraries/classes/Partitioning/Partition.php 25.80% <0.00%> (+8.60%) ⬆️
libraries/classes/Charsets.php 67.27% <0.00%> (+16.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da1f22...e5f9012. Read the comment docs.

@MauricioFauth MauricioFauth force-pushed the ca-bundle branch 2 times, most recently from de35f7b to 8ac047b Compare October 9, 2021 15:45
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a brilliant idea!

@@ -21,6 +21,8 @@ phpMyAdmin - ChangeLog
- issue #16425 Add "DELETE FROM" table on table operations page
- issue #16482 Add a select all link for table-specific privileges
- issue #14276 Add support for account locking
- issue #17143 Use composer/ca-bundle to manage the CA cert file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now we can start using PR ids?
Does the changelog page work great afterwards since it parses the ids to issues urls

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. GitHub redirects to the pull request page.

@MauricioFauth MauricioFauth merged commit 2e1971e into phpmyadmin:master Oct 10, 2021
@MauricioFauth MauricioFauth deleted the ca-bundle branch October 10, 2021 00:26
@MauricioFauth MauricioFauth restored the ca-bundle branch December 9, 2021 14:34
@MauricioFauth MauricioFauth deleted the ca-bundle branch December 9, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants