Add org.opencontainers.image.* labels #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@J0WI can you let me know what you think about this PR ? |
9 tasks
J0WI
reviewed
Mar 17, 2020
J0WI
approved these changes
Mar 17, 2020
ibennetch
approved these changes
Mar 17, 2020
Member
ibennetch
left a comment
ibennetch
left a comment
There was a problem hiding this comment.
This is fine for me, even though I don't personally see much use of LABELs in this way.
Member
Author
They can be used to generate badges and maybe some GUIs use them so I added them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #274 and docker-library/official-images#7288
Spec: https://github.com/opencontainers/image-spec/blob/v1.0.1/annotations.md