Skip to content

Adds PHP 8.4 #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Adds PHP 8.4 #163

merged 7 commits into from
Nov 28, 2024

Conversation

nickschuch
Copy link
Contributor

@nickschuch nickschuch commented Nov 24, 2024

@jmjoy
Copy link
Member

jmjoy commented Nov 25, 2024

  1. You can add #[allow(static_mut_refs)] to solve the warning first

    error: creating a mutable reference to mutable static is discouraged
       --> phper/src/errors.rs:487:31
        |
    487 |                 .push(replace(&mut eg!(exception), null_mut()));
        |                               ^^^^^^^^^^^^^^^^^^^ mutable reference to mutable static
    
  2. You can try to add these functions to the blocklist of phper-sys/build.rs

    error: `extern` block uses type `u128`, which is not FFI-safe
        --> /Users/runner/work/phper/phper/target/release/build/phper-sys-2fa65f16eaf39386/out/php_bindings.rs:9760:44
         |
    9760 |     pub fn zend_startup(utility_functions: *mut zend_utility_functions);
         |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
    

@nickschuch
Copy link
Contributor Author

Down to zend_random_bytes_insecure. I'm not sure how to handle that.

@jmjoy
Copy link
Member

jmjoy commented Nov 25, 2024

Maybe you should block all functions that not FFI-safe.

@nickschuch
Copy link
Contributor Author

I tried zend_random_bytes_insecure but it didn't work. I'm sorry. I'm still quite new to rust.

@jmjoy
Copy link
Member

jmjoy commented Nov 27, 2024

Let me try try.

@jmjoy jmjoy merged commit e5418bb into phper-framework:master Nov 28, 2024
13 of 22 checks passed
@nickschuch nickschuch deleted the php8.4 branch November 30, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants