Skip to content

Refactor clone_obj, remove Object clone methods. #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2023
Merged

Refactor clone_obj, remove Object clone methods. #121

merged 1 commit into from
Apr 30, 2023

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Apr 30, 2023

@jmjoy
Copy link
Member Author

jmjoy commented Apr 30, 2023

Remove ZObject::clone and ZObj::to_owned, because the state maybe not implement Clone.

I want to add the try_clone mehtod, but it's seems that the clone in PHP isn't easy of attainment in extension.

@jmjoy jmjoy merged commit 79e29ee into master Apr 30, 2023
@jmjoy jmjoy deleted the jmjoy/clone branch April 30, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmjoy