-
Notifications
You must be signed in to change notification settings - Fork 19
Allow installation with symfony 6, drop PHP 7.4 support and test against PHP 8.1 #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installation with symfony 6, drop PHP 7.4 support and test against PHP 8.1 #210
Conversation
@dantleech do you have maybe any hint here? I tried to get the test running locally without any success. Tested now the |
Seems like it has todo with jackrabbit: #212. I will try to update jackrabbit in jackalope jackrabbit repository: |
cool, merged that other one |
41c9459
to
fd50ad2
Compare
@dantleech Thank you! looks like we need a release tag that the new version of jackalope jackrabbit is used here. |
c2894da
to
f8c75a0
Compare
f8c75a0
to
a06ebde
Compare
I did fix some PHP 8.1 issues in related packages: But I still got some strange error:
Sadly I'm not sure how to fix this. Any hint here /cc @dbu @dantleech Locally I'm also not able to run all tests as it just stucks at:
Not sure why. |
maybe see what's blocking it? is it stuck connecting to Jackrabbit? or waiting for user input or ... ? |
@dantleech seems to wait for server to response, after a very long time it ends with: so after the following test:
It takes a lot of time and errors with:
but seems like its only a problem on my local system the CI seems to run fine, beside the text utf8 error. |
|
@dantleech yeah jackrabbit works else. the other tests which also require jackrabbit are running. it just when it comes to the
|
no idea i would search for the thing that emits that error and go from there |
38f5b4b
to
8830745
Compare
Found it the error was in jackrabbit. The returned content type was |
8830745
to
6c470b3
Compare
061e1e1
to
5426129
Compare
Thix will add support for Symfony 6. For this It was required to drop PHP 7.4 support and lower, because of
:static
return type.Requires: