Skip to content

Allow installation with symfony 6, drop PHP 7.4 support and test against PHP 8.1 #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 2, 2022

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Apr 20, 2022

Thix will add support for Symfony 6. For this It was required to drop PHP 7.4 support and lower, because of :static return type.

Requires:

@alexander-schranz alexander-schranz changed the title Allow installation with symfony 6 Allow installation with symfony 6 and test against PHP 8.1 Apr 20, 2022
@alexander-schranz alexander-schranz changed the title Allow installation with symfony 6 and test against PHP 8.1 Allow installation with symfony 6, drop PHP 7.4 support and test against PHP 8.1 Apr 20, 2022
@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Apr 20, 2022

@dantleech do you have maybe any hint here? I tried to get the test running locally without any success. Tested now the master branch, there the CI seems also to fail: #211. Not sure what does cause this error.

@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Apr 20, 2022

Seems like it has todo with jackrabbit: #212. I will try to update jackrabbit in jackalope jackrabbit repository:

@dantleech
Copy link
Member

cool, merged that other one

@alexander-schranz alexander-schranz force-pushed the feature/symfony-6-compatibility branch from 41c9459 to fd50ad2 Compare April 20, 2022 20:12
@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Apr 20, 2022

@dantleech Thank you! looks like we need a release tag that the new version of jackalope jackrabbit is used here.

@alexander-schranz alexander-schranz force-pushed the feature/symfony-6-compatibility branch 2 times, most recently from c2894da to f8c75a0 Compare April 29, 2022 11:52
@alexander-schranz alexander-schranz force-pushed the feature/symfony-6-compatibility branch from f8c75a0 to a06ebde Compare April 29, 2022 11:56
@alexander-schranz alexander-schranz marked this pull request as ready for review April 29, 2022 11:57
@alexander-schranz
Copy link
Contributor Author

I did fix some PHP 8.1 issues in related packages:

But I still got some strange error:

  Scenario: Export a subtree                                                    # features/all/phpcr_session_export.feature:18
    Given I execute the "session:export /tests_general_base foobar.xml" command # PHPCR\Shell\Test\EmbeddedContext::iExecuteTheCommand()
    Then the file "foobar.xml" should exist                                     # PHPCR\Shell\Test\EmbeddedContext::theFileShouldExist()
    And the command should not fail                                             # PHPCR\Shell\Test\EmbeddedContext::theCommandShouldNotFail()
      Command failed: (1) [PHPCR\RepositoryException] Unknown encoding of binary data: text/xml; charset=UTF-8
       (Exception)

Sadly I'm not sure how to fix this. Any hint here /cc @dbu @dantleech

Locally I'm also not able to run all tests as it just stucks at:

Feature: Checkout a version
    In order to modify a versionable node
    As a user logged into the shell
    I must be able to execute a command which checksout the node

Not sure why.

@dantleech
Copy link
Member

maybe see what's blocking it? is it stuck connecting to Jackrabbit? or waiting for user input or ... ?

@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Apr 29, 2022

@dantleech seems to wait for server to response, after a very long time it ends with:

so after the following test:

Feature: Checkout a version
    In order to modify a versionable node
    As a user logged into the shell
    I must be able to execute a command which checksout the node

It takes a lot of time and errors with:

┌─ @BeforeScenario # PHPCR\Shell\Test\EmbeddedContext::beforeScenario()
  │
  ╳  Unexpected error:
  ╳  CURL Error: Connection timeout after 300000 ms
  ╳  Response (HTTP 0): PROPFIND
  ╳  --uri: --
  ╳  array (
  ╳    0 => 'http://localhost:8080/server/default',
  ╳  )

but seems like its only a problem on my local system the CI seems to run fine, beside the text utf8 error.

@dantleech
Copy link
Member

curl http://localhost:8080/server/default is the server running locally?

@alexander-schranz
Copy link
Contributor Author

@dantleech yeah jackrabbit works else. the other tests which also require jackrabbit are running. it just when it comes to the Feature: Checkout a version it is stuck, but maybe its just an issue with the jackrabbit and arm cpu. Do you have any hint to the other error which is happening:

      Command failed: (1) [PHPCR\RepositoryException] Unknown encoding of binary data: text/xml; charset=UTF-8
       (Exception)

@dantleech
Copy link
Member

no idea i would search for the thing that emits that error and go from there

@alexander-schranz alexander-schranz force-pushed the feature/symfony-6-compatibility branch from 38f5b4b to 8830745 Compare May 2, 2022 09:03
@alexander-schranz
Copy link
Contributor Author

Found it the error was in jackrabbit. The returned content type was UTF-8 not as expected utf-8 fixed it there: jackalope/jackalope-jackrabbit#170

@alexander-schranz alexander-schranz force-pushed the feature/symfony-6-compatibility branch from 8830745 to 6c470b3 Compare May 2, 2022 09:08
@alexander-schranz alexander-schranz force-pushed the feature/symfony-6-compatibility branch from 061e1e1 to 5426129 Compare May 2, 2022 12:58
@dbu dbu merged commit ecf25e6 into phpcr:master May 2, 2022
@alexander-schranz alexander-schranz deleted the feature/symfony-6-compatibility branch May 2, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants