Skip to content

Fix namespace error in composer 2 #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Conversation

alexander-schranz
Copy link
Contributor

composer dump-autoload --optimize will warn with:

Class Validator located in ./vendor/phpcr/phpcr-shell/src/PHPCR/Shell/Query/Validator.php does not comply with psr-0 autoloading standard. Skipping.

@@ -10,7 +10,7 @@
*
*/

namespace \PHPCR\Shell\Query;
namespace PHPCR\Shell\Query;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@dantleech dantleech merged commit b5f911c into phpcr:master Nov 10, 2020
@dantleech
Copy link
Member

Thanks @alexander-schranz

@alexander-schranz alexander-schranz deleted the patch-1 branch November 10, 2020 12:55
@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Nov 10, 2020

@dantleech thx for merging. Possible to backport this to the 1.1.x version to avoid warnings for older symfony versions also?

@dantleech
Copy link
Member

is there any reason for consumers not to use 1.2?

@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Nov 10, 2020

@dantleech 1.2 requires symfony 5 and if a project requires an older version of symfony like when having sulu 1.6 or 2.0 you will get still this warnings as there 1.1.x will be installed.

@dantleech
Copy link
Member

Tagged 1.1.2 and 1.2.1

@alexander-schranz
Copy link
Contributor Author

@dantleech Thank you! 🎉 🍻

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants