Command node:list (ls): Fix wrong node counter #188
Conversation
|
Thanks for the PR, I'm not really in a position to test these changes at the moment as I don't do any development with PHPCR currently and I can't get Jackrabbit working locally for whatever reason. So I would trust you that this change works. The tests are failing apparently due to unrelated changes in other PHPCR libraries. Would be good to update the test expectations and make the build green before merging this. |
|
can you rebase this on master please? is it possible to write a test for this that could make sure the edge cases are now handled correctly? i notice that the counter is not right in the |
middlebrain
force-pushed
the
ls_wrong_node_count_fix
branch
3 times, most recently
from
6f811d8 to
ccc6f16
Compare
The displayed node counter for "node:list [path_without_wildcards]" is always 1.
middlebrain
force-pushed
the
ls_wrong_node_count_fix
branch
from
ccc6f16 to
0598a4d
Compare
|
I have reworked the fix a little bit and also added two tests. Node counting works now in the same way as property counting in the |
|
Nice work :) |
The displayed node counter for the 'ls' command is always set to 1.