-
Notifications
You must be signed in to change notification settings - Fork 19
[WIP] Refactoring to use container #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
use Symfony\Component\DependencyInjection\Reference; | ||
use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
|
||
class Container extends ContainerBuilder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to use the Symfony DI Container instead of Pimple/whatever as I guess its more likely to be already available when run in embedded mode.
looks good! |
Well it should be possible and not too hard to add a fallback -- but saying that this isn't required by the bundle, its a suggests.. but as long as its not too hard it should be fine. |
Have removed the EmbeddedApplication, instead the MODE should be passed to the Container, and the container passed to the ShellApplication.. hmm. maybe that doesn't work as the EmbeddedApplication does need to auto-exit in command mode. Maybe EmbeddedApplication should instantiate its own Container after all. |
b9b47cd
to
3971683
Compare
|
@@ -1,13 +1,18 @@ | |||
language: php | |||
|
|||
env: | |||
- BEHAT_SUITE=standalone | |||
- BEHAT_SUITE=embedded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now testing with both modes of operation
ef4567b
to
160b340
Compare
- Upgraded to behat 3.0 - Use DI container for everything except commands - Separate test suite for embedded mode - CS fixes
160b340
to
06cd248
Compare
[WIP] Refactoring to use container
This PR introduces dependency injection, fixing #35.and tidying up the mess of helpers.
Todo: