-
Notifications
You must be signed in to change notification settings - Fork 21
Update infrastructure #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Have executed the Jackalope-Doctrine-Dbal test suite and it works. |
$header = <<<EOF | ||
This file is part of the PHPCR API Tests package | ||
|
||
Copyright (c) 2013 Liip and others |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2015
Reverted from |
looks good to me! |
I guess since we use explicit tagged versions in Jackalope, this should also not cause breakage in older branches .. right? |
Yeah, I guess if we have a policy of using explicit versions for phpcr-api-tests in jackalope, it would be safe. But should not break anything even in older versions atm, as its fully BC (tm). |
file that was distributed with this source code. | ||
EOF; | ||
|
||
Symfony\CS\Fixer\Contrib\HeaderCommentFixer::setHeader($header); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when / how is this triggered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would need to be executed manually: /path/to/phpcsfixer fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have that in a doc comment then.
cool, makes sense. i would love to keep the chapter numbers in the namespaces however. can a php namespace start with a number? then we could namespace them as 06Query or something. |
No, it seems namespaces cannot start with numbers. I would suggest to add the chapter information to the class documentation, and also the relevant parts of the spec to each test method doc (if this is not already the case). |
sounds good to me .. |
well, it was very useful to find tests when following the specification. but i guess i will just have to change my habits. the benefits of this PR are worth more than this convenience :-) the spec is not copied into the tests. sometimes the spec subsections covered are mentioned, but not consistently. while that certainly would be great, it sounds like a huge work. lets document the cs fix thingy a bit and then merge this. |
@dantleech thanks! now we need to adjust the jackalopes... |
This PR:
phpcsfixer
configuration (and fix the CS)s/[0-9]{2}_//g
)