Skip to content

Added test for LENGTH operand #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2014

Conversation

wjzijderveld
Copy link

In the test I compare a length literally (=121) and with greater and smaller than.

Is there a PHPCR namespace URI we can use? I now just made something up and most likely wrong :)

@@ -13,6 +13,7 @@
xmlns:jcr="http://www.jcp.org/jcr/1.0"
xmlns:sv="http://www.jcp.org/jcr/sv/1.0"
xmlns:rep="internal"
xmlns:phpcr="http://phpcr.github.io/jcr/phpcr/1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you create this namespace for? i don't see it used anywhere.

indeed this will cause major pain with jackrabbit, as namespaces are global and we use the phpcr namespace already.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it because it caused an error about a invalid XML while I was testing this. But figured that the namespace isn't needed in the general JCR XML. Only in the XML used by jackalope doctrine dbal.

Removed it.

@dbu
Copy link
Member

dbu commented Jan 4, 2014

great. ping when you did that.

@dbu
Copy link
Member

dbu commented Jan 7, 2014

@wjzijderveld we are trying to release jackalope 1.1 - do you have time to finalize this?

@wjzijderveld
Copy link
Author

I probably can make time for it tomorrow evening.

On Tue, Jan 7, 2014 at 9:13 PM, David Buchmann notifications@github.com
wrote:

@wjzijderveld we are trying to release jackalope 1.1 - do you have time to finalize this?

Reply to this email directly or view it on GitHub:
#123 (comment)

@wjzijderveld
Copy link
Author

@dbu I updated the tests.
Maybe the empty-property tests are a bit too much now, Can update it to just test if a = 0 comparison works? As the > is already tested with the string test.

dbu added a commit that referenced this pull request Jan 9, 2014
Added test for LENGTH operand (TODO: phpcr namespace)
@dbu dbu merged commit ca8901f into phpcr:master Jan 9, 2014
@dbu
Copy link
Member

dbu commented Jan 9, 2014

thanks @wjzijderveld i think the < 1 is fine too, does not hurt to have a few edge cases in the tests.

@wjzijderveld wjzijderveld deleted the test-for-length-operand branch January 9, 2014 08:16
@dbu
Copy link
Member

dbu commented Jan 20, 2014

this does not work in jackalope-jackrabbit, see #127

@wjzijderveld if you could have a look, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants