Added test for LENGTH operand#123
Conversation
There was a problem hiding this comment.
what do you create this namespace for? i don't see it used anywhere.
indeed this will cause major pain with jackrabbit, as namespaces are global and we use the phpcr namespace already.
There was a problem hiding this comment.
Added it because it caused an error about a invalid XML while I was testing this. But figured that the namespace isn't needed in the general JCR XML. Only in the XML used by jackalope doctrine dbal.
Removed it.
|
great. ping when you did that. |
|
@wjzijderveld we are trying to release jackalope 1.1 - do you have time to finalize this? |
|
I probably can make time for it tomorrow evening. On Tue, Jan 7, 2014 at 9:13 PM, David Buchmann notifications@github.com
|
… in a separate query
|
@dbu I updated the tests. |
Added test for LENGTH operand (TODO: phpcr namespace)
|
thanks @wjzijderveld i think the < 1 is fine too, does not hurt to have a few edge cases in the tests. |
|
this does not work in jackalope-jackrabbit, see #127 @wjzijderveld if you could have a look, that would be great. |
In the test I compare a length literally (=121) and with greater and smaller than.
Is there a PHPCR namespace URI we can use? I now just made something up and most likely wrong :)