Skip to content

Add an option to return the auth request url #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add an option to return the auth request url #14

wants to merge 1 commit into from

Conversation

michielgerritsen
Copy link

Hello,

Thanks for making this library. I noticed that the createAuthRequest function calls the header function itself to redirect. Because this is hard to test i added an $autoRedirect flag so we can control this behavior, and to be backward compatible.

@pheelixdotcom
Copy link
Contributor

I would like to have this too.

But two things.

  1. the default value for the new parameter should be true, to not brake existing functionality.
  2. You auto redirect the user if the parameter is false. But to my understanding it should be the other way around

@tareqtms
Copy link
Contributor

Fixed with #44

@tareqtms tareqtms closed this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants