Skip to content

Remove credentials #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove credentials #103

wants to merge 1 commit into from

Conversation

KiloooNL
Copy link

Credentials were accidentally supplied... oopsie.

@KiloooNL
Remove credentials
9296f8b 
Credentials were accidentally supplied... oopsie.
@tareqtms
Copy link
Contributor

@KiloooNL
That was intentional so that the tests can run in Travis CI. But you are right that we shouldn't expose credentials here. So I am moving it to environment variables.

@tareqtms tareqtms closed this in 6921da0 Aug 16, 2019
@KiloooNL KiloooNL deleted the patch-1 branch November 17, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KiloooNL @tareqtms