Skip to content

Socket connection added to vscodeclient. #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

Rodrigo-Barros
Copy link

Hi firstly I wanna say thanks for this great work for php community, phpactor ecosystem is awesome.

I wanna give my 2 cents, I made some additions to settings.json of vscode that allow the user:

  • launch and connect to language server via socket mode.
  • pass arguments to language server.

- [x] Option to launch and connect to language server via socket mode.
- [x] Option to pass arguments to language server.
@dantleech dantleech merged commit 2e7c91f into phpactor:master Sep 10, 2022
@dantleech
Copy link
Contributor

Perfect, thanks :)

@dantleech
Copy link
Contributor

Out of curiosity - what's the use case for using the socket connection?

@Rodrigo-Barros
Copy link
Author

Rodrigo-Barros commented Sep 18, 2022

Out of curiosity - what's the use case for using the socket connection?

Some specific scenarios like work on windows but developing for linux systems and WSL was not a option for me.

@dantleech
Copy link
Contributor

I'm pleasantly surprised if it worked on native windows at all - keen to hear any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants