This repository was archived by the owner on Mar 6, 2022. It is now read-only.
WorseNamedParameterCompletor: ignored when completing a variable#59
Merged
dantleech merged 2 commits intoSep 20, 2021
Merged
Conversation
I often find myself in the situation where a function/method's parameter name match the name of a local variable I want to provide as argument. In this situation the completion results include the named parameter which can be anoying depending on the sort done by the client side. I think it's sane to not include named parameters when we already started to type a variable name, our little `$` in php will finally pay off :)
camilledejoye
force-pushed
the
name-param-compeletor-ignore-variables
branch
from
796a2db to
7d06e03
Compare
camilledejoye
commented
Sep 19, 2021
camilledejoye
force-pushed
the
name-param-compeletor-ignore-variables
branch
from
7d06e03 to
ec8d0c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I often find myself in the situation where a function/method's parameter
name match the name of a local variable I want to provide as argument.
In this situation the completion results include the named parameter
which can be annoying depending on the sort done by the client side.
I think it's sane to not include named parameters when we already
started to type a variable name, our little
$in php will finally payoff :)