Skip to content
This repository has been archived by the owner on Mar 6, 2022. It is now read-only.

WorseNamedParameterCompletor: ignored when completing a variable #59

Merged

Conversation

camilledejoye
Copy link
Contributor

I often find myself in the situation where a function/method's parameter
name match the name of a local variable I want to provide as argument.

In this situation the completion results include the named parameter
which can be annoying depending on the sort done by the client side.

image

I think it's sane to not include named parameters when we already
started to type a variable name, our little $ in php will finally pay
off :)

I often find myself in the situation where a function/method's parameter
name match the name of a local variable I want to provide as argument.

In this situation the completion results include the named parameter
which can be anoying depending on the sort done by the client side.

I think it's sane to not include named parameters when we already
started to type a variable name, our little `$` in php will finally pay
off :)
@camilledejoye camilledejoye force-pushed the name-param-compeletor-ignore-variables branch from 796a2db to 7d06e03 Compare September 19, 2021 16:44
@camilledejoye camilledejoye force-pushed the name-param-compeletor-ignore-variables branch from 7d06e03 to ec8d0c0 Compare September 20, 2021 08:47
@dantleech dantleech merged commit f2a2320 into phpactor:master Sep 20, 2021
@camilledejoye camilledejoye deleted the name-param-compeletor-ignore-variables branch September 20, 2021 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants