Replace webmozart/path-util with symfony/filesystem #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
reviewed
Jul 24, 2022
composer.json
Outdated
| "php": "^7.4 || ^8.0", | ||
| "psr/log": "^1.0", | ||
| "webmozart/path-util": "^2.3" | ||
| "psr/log": "^1.0" |
Collaborator
There was a problem hiding this comment.
needs to be in require, currently it's in require-dev
Contributor
Author
There was a problem hiding this comment.
I have just removed the path-util. Should I also move the logger to the dev dependencies?
Collaborator
There was a problem hiding this comment.
sorry, i meant, symfony/filesystem needs to be in require, assuming that this library used the Path:: function
Contributor
Author
There was a problem hiding this comment.
Ah makes sense, I'll do that.
Contributor
Author
|
And about the composer plugins I don't know how we want to handle those. |
Collaborator
|
r.e. the composer plguins, just do what composer says and allow them in |
Contributor
Author
|
Done |
Contributor
Author
|
Is there anything else left to do? |
Collaborator
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.