Change the expected subscribers count to fix the test #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
oliverklee
approved these changes
May 31, 2019
xh3n1
added a commit
that referenced
this pull request
Jun 4, 2019
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
michield
added a commit
that referenced
this pull request
Jan 15, 2025
* change branch name Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com> * Disable REST API by default Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com> * Change path Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com> * Remove prefix Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com> * [FEATURE] Get the number of subscribers of list and added tests (#116) Closes #115 * [BUGFIX] Fix the expected number in an integration test (#119) Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com> * [CLEANUP] Fix a warning with newer PHPMD versions (#125) * update php dependencies * update to pass building * ISSUE-337: update package versions * ISSUE-337: use local * ISSUE-337: symfony 6.4 * ISSUE-337: test fix * ISSUE-337: fix the rest of tests * GitHub actions (#132) * added github workflow(action) for build and test ci tasks Signed-off-by: fenn-cs <fenn25.fn@gmail.com> * updated php_codesniffer dep Signed-off-by: fenn-cs <fenn25.fn@gmail.com> * removed travis ci config file Signed-off-by: fenn-cs <fenn25.fn@gmail.com> (cherry picked from commit 70d45ad) * ISSUE-337: add pipeline * ISSUE-337: fix phpstan * ISSUE-337: fix phpstmd * ISSUE-337: openapi docs * ISSUE-337: move to bundle file * ISSUE-337: changelog * ISSUE-337: update core * ISSUE-337: fix phpstan * ISSUE-337: fix phpcs * ISSUE-337: force push * ISSUE-337: name fix --------- Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com> Co-authored-by: Xheni Myrtaj <myrtajxheni@gmail.com> Co-authored-by: Oliver Klee <oliver@phplist.com> Co-authored-by: Michiel Dethmers <michiel@phplist.com> Co-authored-by: Tatevik <tatevikg1@gmail.com> Co-authored-by: F. E Noel Nfebe <fenn25.fn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The expected number of subscribers for listid=2 is actually 2
https://github.com/phpList/rest-api/blob/master/tests/Integration/Controller/Fixtures/Subscription.csv