[TASK] Ignore domains with unknows directives and textroles #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linawolf
force-pushed
the
task/ignore-domain
branch
from
631cf27 to
10f3e7c
Compare
linawolf
force-pushed
the
task/ignore-domain
branch
from
10f3e7c to
fada0dd
Compare
Member
|
Does this also enable known directives and roles in a certain domain? I guess when I read this code it doesn't, so it ignores only the unknown? |
Contributor
Author
|
For now it only disables unknown directives with domain. We do have no central domain handling in place right now. But introducing such would be beyond the scope of this PR. I think we need to give it more thought. This PR enables us to check for warnings in the docs again and therefore prevent other kind of warnings |
linawolf
changed the title
jaapio
approved these changes
Mar 1, 2024
jaapio
force-pushed
the
task/ignore-domain
branch
from
ef2bdc3 to
c784542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.