[BUGFIX] Handle "dirty" objects.inv.json data #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linawolf
force-pushed
the
bugfix/interlinks
branch
from
84c9c99 to
d7595c4
Compare
brotkrueml
reviewed
Feb 19, 2024
Contributor
brotkrueml
left a comment
brotkrueml
left a comment
There was a problem hiding this comment.
Sorry, currently I don't have enough information for a review: Which content holds $linkArray?
Contributor
Author
|
$linkArraycomes from the imported JSON data, see the fixtures in the Unit Tests https://github.com/phpDocumentor/guides/pull/853/files#diff-615ca620b21221a05c303d924a986d8334be1c95db29e038e95c7a23d60f21b1 |
packages/guides/src/ReferenceResolvers/Interlink/DefaultInventoryLoader.php
Outdated
Show resolved
Hide resolved
linawolf
force-pushed
the
bugfix/interlinks
branch
from
d7595c4 to
f34462f
Compare
Handle null values as not set, ignore inventory entries that have non-scalar values or null in the URI. Until now those were causing type errors
linawolf
force-pushed
the
bugfix/interlinks
branch
from
f34462f to
26aaa17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle null values as not set, ignore inventory entries that have non-scalar values or null in the URI.
Until now those were causing type errors