!!![TASK] Warn only once when a reference cannot be resolved #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
reviewed
Dec 31, 2023
Member
jaapio
left a comment
jaapio
left a comment
There was a problem hiding this comment.
Why are the messages nullable? was this an attempt to not make this a breaking change?
packages/guides/src/ReferenceResolvers/DelegatingReferenceResolver.php
Outdated
Show resolved
Hide resolved
linawolf
force-pushed
the
task/improve-link-reporting
branch
from
87548a1 to
324e6cc
Compare
jaapio
approved these changes
Jan 2, 2024
This is a breaking change to those who have implemented a custom ReferenceResolver.
jaapio
force-pushed
the
task/improve-link-reporting
branch
from
324e6cc to
d977694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change to those who have implemented a custom ReferenceResolver.