[FEATURE] add configuration block directive #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
force-pushed
the
feature/configuration-tab
branch
from
ddf33ff to
96a6cbf
Compare
|
Maybe we should change the template a bit to work with this css trick: https://css-tricks.com/examples/CSSTabs/radio.php |
greg0ire
reviewed
Dec 30, 2023
...ges/guides-restructured-text/src/RestructuredText/Directives/ConfigurationBlockDirective.php
Outdated
Show resolved
Hide resolved
greg0ire
reviewed
Dec 30, 2023
packages/guides-restructured-text/resources/config/guides-restructured-text.php
Show resolved
Hide resolved
The default theme doesn't come with CSS though as far as I know. Maybe we can use In the bootstrap extension, we have to override this anyways to use BootstrapCSS's tabs styling. And the same applies to Symfony. |
wouterj
reviewed
Dec 30, 2023
...des-restructured-text/src/RestructuredText/DependencyInjection/ReStructuredTextExtension.php
Show resolved
Hide resolved
...ges/guides-restructured-text/src/RestructuredText/Directives/ConfigurationBlockDirective.php
Outdated
Show resolved
Hide resolved
...ges/guides-restructured-text/src/RestructuredText/Directives/ConfigurationBlockDirective.php
Outdated
Show resolved
Hide resolved
This "Trick" is not accessible however. |
jaapio
force-pushed
the
feature/configuration-tab
branch
from
96a6cbf to
2a2bce9
Compare
linawolf
reviewed
Dec 31, 2023
linawolf
reviewed
Dec 31, 2023
tests/Integration/tests/directives/directive-configuration-block/input/guides.xml
Show resolved
Hide resolved
linawolf
approved these changes
Dec 31, 2023
wouterj
reviewed
Dec 31, 2023
...ges/guides-restructured-text/src/RestructuredText/Directives/ConfigurationBlockDirective.php
Outdated
Show resolved
Hide resolved
wouterj
reviewed
Dec 31, 2023
jaapio
force-pushed
the
feature/configuration-tab
branch
from
61ce8ba to
db45967
Compare
linawolf
force-pushed
the
feature/configuration-tab
branch
from
db45967 to
f1453d7
Compare
|
@jaapio shall we merge this? |
Add the implementation of the configuration block directive. To make the implemtation more generic a configuration option is introduced. This will allow the users to configure their own labels. Co-authored-by: Wouter de Jong <wouterj@users.noreply.github.com>
jaapio
force-pushed
the
feature/configuration-tab
branch
from
654c270 to
8ef9662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the implementation of the configuration block directive. To make the implemtation more generic a configuration option is introduced. This will allow the users to configure their own labels.