Cache matching node renderers #784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By caching which node renderer can be used for which node, we can avoid a lot of foreach loops.
From a quick local test (with pcov enabled), this improved run time by 50%. Blackfire diff: https://blackfire.io/profiles/compare/9aa42af9-7692-418c-9d34-f7e010a22f8f/graph
We can optionally do this in a non-BC breaking way by introducing a new cacheable interface with a
supportsFqcn()
method (similar to Symfony's voter caching). However, I can find no node renderer in guides and Symfony that does something other thaninstanceof
. So I would favor simplicity for the years to come over this BC break.But I'm happy to discuss rewriting this to a smooth upgrade path if this helps TYPO3.