Fix: allow absolute image urls #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able link to external urls we need to check at multiple places how to handle the url. fixes #621
jaapio
force-pushed
the
fix/absolute_image_url
branch
from
6583c64 to
42ce7ff
Compare
linawolf
approved these changes
Oct 21, 2023
Contributor
linawolf
left a comment
linawolf
left a comment
There was a problem hiding this comment.
Looks good to me, didnt even know, that was possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able link to external urls we need to check at multiple places how to handle the url.
fixes #621