Skip to content

Fix: allow absolute image urls #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Fix: allow absolute image urls #626

merged 1 commit into from
Oct 21, 2023

Conversation

jaapio
Copy link
Member

@jaapio jaapio commented Oct 17, 2023

To be able link to external urls we need to check at multiple places how to handle the url.

fixes #621

@jaapio jaapio requested a review from linawolf October 17, 2023 20:23
To be able link to external urls we need to check at multiple
places how to handle the url.

fixes #621
@jaapio jaapio force-pushed the fix/absolute_image_url branch from 6583c64 to 42ce7ff Compare October 19, 2023 14:09
Copy link
Contributor

@linawolf linawolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, didnt even know, that was possible

@linawolf linawolf merged commit 476d691 into main Oct 21, 2023
@linawolf linawolf deleted the fix/absolute_image_url branch October 21, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RST image directive tries to load images from local, even if explicitly passed as absolute URLs
2 participants