-
-
Notifications
You must be signed in to change notification settings - Fork 15
Allow setting a default language for literal blocks #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting a default language for literal blocks #608
Conversation
...des-restructured-text/src/RestructuredText/DependencyInjection/ReStructuredTextExtension.php
Outdated
Show resolved
Hide resolved
We do save the language in each LiteralInlineNode, which is already part of the guides. So why don't we make this part of the guides and Save it in the ProjectSettings? It is a useful feature for other input formats as well. Also I think we should keep all Settings in the Settings Manager so that they are easy to find and not scattered throughout the project. We could make a way that extensions can save their setting objects in the settings Manager? |
a0dcb1d
to
d069510
Compare
Good suggestions, I've moved the setting to |
I would suggest to add an integration test that demonstrates this setting. Integration tests do respect the guides.xml |
I am going to rebase this and see what I can do about the integration tests |
d069510
to
3f5aae9
Compare
@wouterj could you have a look why the integration tests are not working? |
Ah ok, I think I figured it out. it needs to be set as an argument of the guides tag now, however we need to change the description of your commit and the guides.xsd |
359904b
to
371b0c8
Compare
0412acd
to
c7dad02
Compare
Besides setting the local language using the
.. highlight::
directive, Sphinx also allows specifying a global default language for literal blocks. We use this in Symfony to mark all literal blocks as "php".After this PR, you can configure the default language in
guides.xml
: