Feat: Add plantuml server rendering #603
Conversation
| '$plantumlServerUrl', | ||
| '%guides.graphs.plantuml_server%', | ||
| ) | ||
| ->alias(DiagramRenderer::class, PlantumlServerRenderer::class) |
There was a problem hiding this comment.
For now this is not configurable, the configuration options are there, but I need to add a service locator that allows you to register any class.
| $extensionAlias = $this->registeredExtensions[$extensionFqcn] ?? false; | ||
| if (!$extensionAlias) { | ||
| $this->registerExtension(new $extensionFqcn()); | ||
| $this->registerExtension(new $extensionFqcn(), $config); |
There was a problem hiding this comment.
@wouterj I think you missed this when implementing the extension config? Otherwise only default extensions can be configured, not the ones configured in the guides.xml?
There was a problem hiding this comment.
You're right 👍
I think I originally intended this without the early return on the next line (so we "register" the extension without config, and then add extra config). But this works as well.
linawolf
left a comment
linawolf
left a comment
There was a problem hiding this comment.
I think it is a good start!
|
@jaapio should we merge this? Further open issues can be adressed afterwards |
This patch makes is possible to load configuration for extensions that are not loaded by default. This gives us the option to add configuration to the graph extension. By now this extension supports the options to use an remote plantuml server to render uml diagrams.
jaapio
force-pushed
the
feat/plantuml-rendering
branch
from
5d822c3 to
4857cfe
Compare
This patch makes is possible to load configuration for extensions that are not loaded by default. This gives us the option to add configuration to the graph extension.
By now this extension supports the options to use an remote plantuml server to render uml diagrams.