Feat: Add plantuml server rendering #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
commented
Sep 26, 2023
| '$plantumlServerUrl', | ||
| '%guides.graphs.plantuml_server%', | ||
| ) | ||
| ->alias(DiagramRenderer::class, PlantumlServerRenderer::class) |
There was a problem hiding this comment.
For now this is not configurable, the configuration options are there, but I need to add a service locator that allows you to register any class.
jaapio
commented
Sep 26, 2023
| @@ -54,7 +54,7 @@ public function loadExtensionConfig(string $extension, array $config): void | |||
|
|
|||
| $extensionAlias = $this->registeredExtensions[$extensionFqcn] ?? false; | |||
| if (!$extensionAlias) { | |||
| $this->registerExtension(new $extensionFqcn()); | |||
| $this->registerExtension(new $extensionFqcn(), $config); | |||
There was a problem hiding this comment.
@wouterj I think you missed this when implementing the extension config? Otherwise only default extensions can be configured, not the ones configured in the guides.xml?
There was a problem hiding this comment.
You're right 👍
I think I originally intended this without the early return on the next line (so we "register" the extension without config, and then add extra config). But this works as well.
linawolf
approved these changes
Sep 28, 2023
|
@jaapio should we merge this? Further open issues can be adressed afterwards |
This patch makes is possible to load configuration for extensions that are not loaded by default. This gives us the option to add configuration to the graph extension. By now this extension supports the options to use an remote plantuml server to render uml diagrams.
jaapio
force-pushed
the
feat/plantuml-rendering
branch
from
5d822c3 to
4857cfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes is possible to load configuration for extensions that are not loaded by default. This gives us the option to add configuration to the graph extension.
By now this extension supports the options to use an remote plantuml server to render uml diagrams.