[FEATURE] Add option input-file to render a specific file #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
reviewed
Sep 26, 2023
| <guides | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="https://www.phpdoc.org/guides packages/guides-cli/resources/schema/guides.xsd" | ||
| input-file="README.rst" |
There was a problem hiding this comment.
I do understand this use case on the commandline, but is it required to have this in the configuration file? That doesn't really make sense to me.
There was a problem hiding this comment.
Where is the Harm of having it in the configuration file as we have basically all settings that you can do in the command line also in the configuration file, why should we divide from that here?
There was a problem hiding this comment.
@jaapio how shall we resolve this?
|
@jaapio how shall we proceed? |
jaapio
approved these changes
Oct 13, 2023
This can be used to parse READMEs or other standalone reST files. It is also a preparation for rendering specific mark down files in future like a README.md
jaapio
force-pushed
the
feature/renderSingleFile
branch
from
bc31c35 to
d32ad0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to parse READMEs or other standalone reST files. It is also a preparation for rendering specific mark down files in future like a README.md