Skip to content

Conversation

@linawolf
Copy link
Contributor

This can be used to parse READMEs or other standalone reST files. It is also a preparation for rendering specific mark down files in future like a README.md

<guides
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://www.phpdoc.org/guides packages/guides-cli/resources/schema/guides.xsd"
input-file="README.rst"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do understand this use case on the commandline, but is it required to have this in the configuration file? That doesn't really make sense to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the Harm of having it in the configuration file as we have basically all settings that you can do in the command line also in the configuration file, why should we divide from that here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaapio how shall we resolve this?

@linawolf
Copy link
Contributor Author

@jaapio how shall we proceed?

@linawolf linawolf requested a review from jaapio October 11, 2023 15:15
This can be used to parse READMEs or other standalone
reST files. It is also a preparation for rendering specific mark down files in future like a
README.md
@jaapio jaapio force-pushed the feature/renderSingleFile branch from bc31c35 to d32ad0f Compare October 13, 2023 06:40
@jaapio jaapio enabled auto-merge October 13, 2023 06:41
@jaapio jaapio merged commit 9e399ab into main Oct 13, 2023
@jaapio jaapio deleted the feature/renderSingleFile branch October 13, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants