[BUGFIX] Make setting theme in guides.xml work #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
reviewed
Sep 22, 2023
linawolf
force-pushed
the
bugfix/html-theme
branch
2 times, most recently
from
15fad82 to
0def8eb
Compare
linawolf
changed the title
jaapio
approved these changes
Sep 23, 2023
Until now the theme was set before all themes where loaded causing an error because the theme was not found.
We can get rid of the need of having a separate test class for these test cases
jaapio
force-pushed
the
bugfix/html-theme
branch
from
0def8eb to
0b569ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the theme was set before all themes where loaded causing an error because the theme was not found.