[FEATURE] Introduce table directive #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
requested changes
Sep 4, 2023
Comment on lines
33
to
37
| {% if width<=0 %} | ||
| <col style="width: auto"> | ||
| {% else %} | ||
| <col style="width: {{ width }}%"> | ||
| {% endif %} |
There was a problem hiding this comment.
Suggested change
| {% if width<=0 %} | |
| <col style="width: auto"> | |
| {% else %} | |
| <col style="width: {{ width }}%"> | |
| {% endif %} | |
| <col style="width: {{ width | default 'auto' }}"> |
There was a problem hiding this comment.
This would not catch the width being 0 or smaller?
linawolf
force-pushed
the
feature/table
branch
from
f5a779e to
31274a3
Compare
|
@jaapio please have another look at my answers and solutions |
linawolf
force-pushed
the
feature/table
branch
from
31274a3 to
c76f0b3
Compare
jaapio
approved these changes
Sep 9, 2023
So that each part can be changed individually
jaapio
force-pushed
the
feature/table
branch
from
a617540 to
860aa62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.