!![TASK] Replace the subparser with a starting rule in directives #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
reviewed
Aug 23, 2023
...es/guides-restructured-text/src/RestructuredText/Parser/Productions/DirectiveContentRule.php
Outdated
Show resolved
Hide resolved
linawolf
force-pushed
the
bugfix/fieldlistdirective
branch
from
e19573d to
6a8da8e
Compare
This change is breaking for anyone who implemented a SubDirective with a constructor as now the parent constructor has to be called. It also fixes the bug of disappearing field lists in direcitves. getSubParser is only used in 2 other places that can be dealed with in a follow up such that we can remove the deprecated method all together
linawolf
force-pushed
the
bugfix/fieldlistdirective
branch
from
6a8da8e to
b1a023e
Compare
jaapio
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is breaking for anyone who implemented a SubDirective with a constructor as now the parent constructor has to be called. It also fixes the bug of disappearing field lists in direcitves.
getSubParser is only used in 2 other places that can be dealed with in a follow up such that we can remove the deprecated method all together,
I also removed the subparser in the Blockquotes. So it is only used in the include directive now.