[FEATURE] Introduce Breadcrumb #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linawolf
force-pushed
the
feature-breadcrumb
branch
from
f99cda3 to
74314e6
Compare
jaapio
reviewed
Aug 21, 2023
There was a problem hiding this comment.
There seems to be quiet some logic in the renderer. It would have been nice if we could move some of this logic to the compiler. This would be more in line with the way toctree and menu are working.
If you see it from an abstract level a breadcrumb path could be some flat menu structure where every node has a single child. Given the fact toctrees have an impact on the structure of documents, I think it is wise to use this same structure in breadcrumbs.
jaapio
reviewed
Aug 21, 2023
The breadcrumb can either be inserted as directive of that name or directly into the template by using the twig function {{ renderBreadcrumb() }}. See Bootstrap theme as example for the latter
linawolf
force-pushed
the
feature-breadcrumb
branch
from
74314e6 to
c424384
Compare
jaapio
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breadcrumb can either be inserted as directive of that name or directly into the template by using the twig function {{ renderBreadcrumb() }}. See Bootstrap theme as example for the latter