!!![TASK] Move LineIterators to Block Context #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloning the DocumentContext prevents data to be set on a per DocumentLevel as we will have several contextes per document then
The current content is now handled in the BlockContext
jaapio
force-pushed
the
bugfix-documentParserContext
branch
from
116d73e to
cdc9bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a breaking change. However we had a real flaw in design here. We stored blocks of lines as line iterator in the DocumentParserContext that do not represent the document. To prevent adverse effects we cloned the DocumentParserContext. But this means that all data stored in the document context can get lost because it is set in a clone and not the original context.
This is needed to make #534 work