Chore/phpstan strict #479
Merged
Chore/phpstan strict #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
force-pushed
the
chore/phpstan-strict
branch
from
54a5203 to
6afc535
Compare
jaapio
force-pushed
the
chore/phpstan-strict
branch
3 times, most recently
from
f47136d to
dee36ed
Compare
Contributor
|
Could we wait with them until we have the big PRs merged? Otherwise we will have conflict hell |
Member
Author
|
Yes, I will keep this up to date :-) |
linawolf
approved these changes
Aug 12, 2023
Contributor
linawolf
left a comment
linawolf
left a comment
There was a problem hiding this comment.
I think this looks good
Contributor
|
Please resolve conflicts before merging |
jaapio
force-pushed
the
chore/phpstan-strict
branch
from
dee36ed to
36f48d5
Compare
To be able to detect more code violations, be more strict.
jaapio
force-pushed
the
chore/phpstan-strict
branch
from
36f48d5 to
17e96c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up of the code: