Improved exclude file options #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
force-pushed
the
cleanup-run-command
branch
from
1cc9feb to
86ff5ee
Compare
By moving the progress bar configuration into a separate class we can make the run command more lean. This will allow some improvements in the future.
Excludes do now support glob patterns and are handled in a centralized class. Users can now define them in the config rather then having to pass a commandline option.
jaapio
force-pushed
the
cleanup-run-command
branch
from
86ff5ee to
bd0e218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the progressbar logic to a separate class, to make it easier to trace what is happening in the run command.
The exclude options are now extended and compatible with the way phpdocumentor supports this for file collection. This will help libraries implementing cli extensions to add excludes in the settings rather than passing them into to command.