[FEAT] add support for raw html sanitizers #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on fixing the phpstan issues |
This feature introduces a new compiler pass that will allow us to sanitize the html in a raw directive. We can disable the full raw usage by setting `raw_node.escape` to `true` this will block all html and displays the raw node as normal paragraph. By default the raw directive is displayed as is and sanitized to safe html, when raw is defined as html content ``` .. raw:: html <p>html here</p> ``` if the raw language is different than html we no nothing for now. This pr also allows the users to define there own html sanitizer from the configuration. Example can be found in the included test.
linawolf
force-pushed
the
feature/sanitize-raw-html
branch
from
678a28f to
7378a62
Compare
linawolf
approved these changes
Oct 11, 2024
|
Thanks, looks good to me |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jaapio
added a commit
that referenced
this pull request
Oct 11, 2024
[1.x] Merge pull request #1125 from phpDocumentor/feature/sanitize-raw-html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature introduces a new compiler pass that will allow us to sanitize the html in a raw directive. We can disable the full raw usage by setting
raw_node.escapetotruethis will block all html and displays the raw node as normal paragraph.By default the raw directive is displayed as is and sanitized to safe html, when raw is defined as html content
if the raw language is different than html we no nothing for now.
This pr also allows the users to define there own html sanitizer from the configuration. Example can be found in the included test.