Skip to content

[Bug]: Command does not fail on error only #1188

Open
@dkd-kaehm

Description

@dkd-kaehm

Summary

The --fail-on-log and --minimal-test do not work as expected.
The command does not fail with --fail-on-log, if doc-sources contain errors only.

Expected:

The command

  • with --fail-on-error MUST fail, if there are errors (currently OK), but
  • with --fail-on-log or --minimal-test MUST fail, if there are errors OR warnings

NOTE:

This is difficult to reproduce, so I could not create a simple test case, but it is reproducible in our project in file(EXT:solr VersionMatrix.rst).
Most probably due of multiple tables producing the errors or other stuff containing in that file.

Code snippet that reproduces the problem

Prepare:

git clone https://github.com/TYPO3-Solr/ext-solr.git \
  && cd ext-solr \
  && git reset --hard 4f7b9a73e5cce6f7d836eb3726d0b3e2a48e4310

Test:

MUST fail, but doesn't (See: EXPECTED TO BE PRINTED! is not printed)

docker run --rm --pull always -v "$(pwd)":/project -t ghcr.io/typo3-documentation/render-guides:latest --config=Documentation --fail-on-log || echo 'EXPECTED TO BE PRINTED!'
rm -Rf Documentation-GENERATED-temp/

Fails only if warning is produced(relevant for info only!)

echo -e '\nproduce the warning: |nonExistingVar|' > Documentation/Appendix/VersionMatrix.rst
docker run --rm --pull always -v "$(pwd)":/project -t ghcr.io/typo3-documentation/render-guides:latest --config=Documentation --fail-on-log || echo 'EXPECTED TO BE PRINTED!'
rm -Rf Documentation-GENERATED-temp/

Expected output

Not relevant for rendering.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtriage

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions