Fix issue when processing invalid tags #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invalid tags are processed a null was returned causing all kind of issues in the normal behavior of this libary. As a solution a generic tag could be created. But that would just drop the error information in. Therefore a new tag was introduced, `invalidTag` the tag is just like the generic tag but does contain the error triggered during the creation of the tag. Which might help applications like phpdocumentor to display validation issues.
mvriel
reviewed
Jan 12, 2020
mvriel
reviewed
Jan 12, 2020
mvriel
approved these changes
Jan 12, 2020
Member
mvriel
left a comment
mvriel
left a comment
There was a problem hiding this comment.
Reviewed; with a couple of suggestions for possible improvements
jaapio
force-pushed
the
fix/invalid-tag-usage-fix
branch
from
135db42 to
bb629f6
Compare
Member
Author
|
Thanks for the review. Updated the code and merged it to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invalid tags are processed a null was returned causing all kind
of issues in the normal behavior of this libary. As a solution a generic tag
could be created. But that would just drop the error information in.
Therefore a new tag was introduced,
invalidTagthe tag is just like thegeneric tag but does contain the error triggered during the creation of the
tag. Which might help applications like phpdocumentor to display validation issues.