Skip to content

Enhancement: Enable switch_case_space fixer #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 16, 2022

This pull request

  • enables the switch_case_space fixer
  • runs make coding-standards

Follows #559.

💁‍♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/control_structure/switch_case_space.rst.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Adding the switch_case_space fixer looks reasonable to me, but I'd reformat one of the switches (partially to avoid discussion of whether it is better to align the colons).

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@localheinz localheinz force-pushed the feature/switch-case-space branch from 9710d9b to 1ca5c29 Compare July 17, 2022 10:25
@localheinz
Copy link
Contributor Author

@cmb69 @kamil-tekiela

Is this good to go?

@cmb69 cmb69 merged commit cdb8324 into php:master Aug 22, 2022
@cmb69
Copy link
Member

cmb69 commented Aug 22, 2022

Is this good to go?

Yes. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants