Improve code formatting in JS #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have that formatting automated, like we did with php-cs-fixer? We could start with only this file. |
|
I don't know if we could automate that. We could think of simply using TSC to compile JS and commit that, but TSC removes blank lines... so in terms of readability, it's not great. I don't know what other automatic formatter we could use that would give us good results. I think there are a number of linters and different coding styles available for JavaScript. I think as a first step, what I propose is sensible. At least the formatting is more uniform in this one file, even if we don't enforce any particular coding style for JS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only applies more consistent code formatting to the common.js file. I understand it's highly opinionated, but I do find this easier to read. This was done using TSC compiled, automatic formatted, and some manual adjustments. This PR contains no refactoring, code clean-up or any other changes to the code. It's all purely visual.