Skip to content

Enhancement: Enable visibility_required fixer #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2022
Merged

Enhancement: Enable visibility_required fixer #639

merged 2 commits into from
Jul 11, 2022

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 11, 2022 •
edited
Loading

This pull request

  • enables the visibility_required fixer
  • runs make coding-standards

Follows #559.

💁‍♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/class_notation/visibility_required.rst.

cmb69
cmb69 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you! Needs rebase, though.

@localheinz localheinz force-pushed the feature/visibility-required branch from e1eca40 to ad8d340 Compare July 11, 2022 18:15
@localheinz
Copy link
Contributor Author

@cmb69

Rebased!

@cmb69 cmb69 merged commit ba92fc9 into php:master Jul 11, 2022
@localheinz localheinz deleted the feature/visibility-required branch July 11, 2022 18:17
@localheinz
Copy link
Contributor Author

Thank you, @cmb69!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @cmb69