Skip to content

Enhancement: Enable whitespace_after_comma_in_array fixer #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 11, 2022

This pull request

  • enables the whitespace_after_comma_in_array fixer
  • runs make coding-standards

Follows #559.

πŸ’β€β™‚οΈ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/array_notation/whitespace_after_comma_in_array.rst.

@localheinz localheinz marked this pull request as ready for review July 11, 2022 17:38
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks sufficiently uncontroversal. Could you please fix the merge conflicts?

@localheinz localheinz force-pushed the feature/whitespace-after-comma-in-array branch from a28fc5a to 8be8828 Compare July 11, 2022 17:59
@localheinz
Copy link
Contributor Author

@cmb69

Rebased!

@cmb69 cmb69 merged commit 4b3e3c9 into php:master Jul 11, 2022
@cmb69
Copy link
Member

cmb69 commented Jul 11, 2022

Thank you!

@localheinz localheinz deleted the feature/whitespace-after-comma-in-array branch July 11, 2022 18:13
@localheinz
Copy link
Contributor Author

Thank you, @cmb69!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants