Fix: Remove useless function #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-tekiela
approved these changes
Jun 28, 2022
How can I find out if any of them is using this stuff? |
|
That would break the manual, since every single manual page calls this function. Note that files under manual/en are just a few examples; the actual files are rendered by PhD, and there we would need to delete this line: https://github.com/php/phd/blob/c3868a838e5029e7cbe39868a1c146e9b81c4986/phpdotnet/phd/Package/PHP/Web.php#L207 After that has been done, and the manual has been successfully rebuilt (happens every 4 or 6 hours), we can merge this PR. |
|
I thought so. Let's leave it as it is for now. |
1 task
|
Thank you, @cmb69 and @kamil-tekiela! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
manual_header()