Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LAST_LANG cookie as it is not used anymore. #1072

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

takaram
Copy link
Contributor

@takaram takaram commented Sep 15, 2024

The "last seen language" is no longer respected since 4 years ago.
So we should stop setting the LAST_LANG cookie.

See 7691b44 and https://bugs.php.net/bug.php?id=79524

Copy link

🚀 Regression report for commit c9a1c7c is at https://web-php-regression-report-pr-1072.preview.thephp.foundation

Copy link

🚀 Preview for commit c9a1c7c can be found at https://web-php-pr-1072.preview.thephp.foundation

Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you!

Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@saundefined saundefined merged commit c7425ed into php:master Sep 17, 2024
5 checks passed
@takaram takaram deleted the remove_last_lang_cookie branch September 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants