Remove special cases for the gettext shorthand function #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Commit 7b11b96 Deployed on https://web-php-pr-1029.preview.thephp.foundation |
MauricioFauth
force-pushed
the
gettext-underscore-alias
branch
from
3335c5f
to
57f3f82
Compare
saundefined
approved these changes
Jul 15, 2024
MauricioFauth
added a commit
to php/doc-en
that referenced
this pull request
Jul 19, 2024
The _() function is an alias of the gettext() function. Adding a dedicated manual page for this function will remove the need for the special cases created for it when generating the manual. See: - https://bugs.php.net/bug.php?id=63490 - php/systems@b67fa16 - php/web-php@fdec771 - https://github.com/php/php-src/blob/PHP-4.0/ext/gettext/gettext.c#L39 - php/web-php#1029 - php/systems#23
|
Documentation PR was merged and is already live. |
sy-records
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After php/doc-en#3556 being merged, these special cases for the
gettext()shorthand_()will not be needed anymore.