Remove escapeshellarg() quoting for configure flags
#94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This quoting is not necessary and in fact actively harmful, because the `./configure` command is not passed to a shell as a string where word-splitting happens, but as an argv array which the process will use as-is. As an example, previously providing the `--with-library=/tmp/foo` flag would result in the `--with-library='/tmp/foo'` flag being passed as the argument, which then would be interpreted as if `"--with-library='/tmp/foo'"` was entered into a shell. In other words: The library was expected to be found in a directory literally starting with a single-quote.
Collaborator
|
Thanks @TimWolla ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This quoting is not necessary and in fact actively harmful, because the
./configurecommand is not passed to a shell as a string where word-splitting happens, but as an argv array which the process will use as-is.As an example, previously providing the
--with-library=/tmp/fooflag would result in the--with-library='/tmp/foo'flag being passed as the argument, which then would be interpreted as if"--with-library='/tmp/foo'"was entered into a shell. In other words: The library was expected to be found in a directory literally starting with a single-quote.