Skip to content

Cleanup on aisle vendor #157

Description

@asgrim

After discussing with @derickr a bit, everything in the PIE working directory vendor except vendor/composer/installed.json is mostly just taking up space. It isn't used as a cache for subsequent (re)installs, so it is just taking up space.

Apparently Datadog ext is very large, so this could become problematic if we don't clean up. I imagine some kind of post install cleanup step can run that removes vendor/* (except vendor/composer), could work, although I need to investigate viability and impact.

Activity

  1. remicollet commented on Dec 24, 2024

    @remicollet
    Member

    Related to this, what is the goal of building in user home directory ?
    Using any temporary directory will be fine (and usually temp have auto cleanup feature)

    I understand composer use ~/.composer for global Installation, commands in ~/.composer/vendor/bin are usable

  2. asgrim commented on Dec 24, 2024

    @asgrim
    ContributorAuthor

    Related to this, what is the goal of building in user home directory ?

    See ThePHPF/pie-design#26 - TLDR, it will help us to auto-upgrade extension in the future, e.g. just running pie update will be able to update all the currently PIE-sourced extensions

  3. remicollet commented on Dec 24, 2024

    @remicollet
    Member

    I understand the need to store some metadata (pie.json), but not the build

  4. asgrim commented on Dec 24, 2024

    @asgrim
    ContributorAuthor

    I understand the need to store some metadata (pie.json), but not the build

    That is just how Composer works - you give it the path to composer.json (although we call it pie.json to avoid confusion) and it does the lock/vendor stuff itself. The key files we actually want to keep is pie.json, pie.lock, but we also need vendor/composer/installed.json, since the latter file is the one that actually has the build metadata.

  5. self-assigned this
    on Jan 2, 2025
  6. added this to the 0.5.0 milestone on Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions