Skip to content

Fix json_validate double free in parser when discarding lookahead #9696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2022
Merged

Fix json_validate double free in parser when discarding lookahead #9696

merged 2 commits into from
Oct 9, 2022

Conversation

@iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 requested a review from TysonAndre October 9, 2022 09:34
@iluuu1994
Copy link
Member Author

Hm not sure why the build fails. I'll have to check.

@juan-morales
Copy link
Contributor

@iluuu1994

image

juan-morales
juan-morales reviewed Oct 9, 2022
View reviewed changes
@juan-morales
Copy link
Contributor

locally for me, current change works. All tests passed.

Lets see the pipeline

@juan-morales
Copy link
Contributor

🟢 🍏 📗 💚

@iluuu1994 iluuu1994 merged commit 08e8862 into php:master Oct 9, 2022
@iluuu1994 iluuu1994 deleted the fix-json-validate-use-after-free branch October 9, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TysonAndre TysonAndre Awaiting requested review from TysonAndre

1 more reviewer

@juan-morales juan-morales juan-morales left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Extension: json

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iluuu1994 @juan-morales